linux-kernel - Re: [PATCH tip/core/rcu 2/2] virt/kvm: Replace spin_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190110185200.GU1215@linux.ibm.com>
Date:   Thu, 10 Jan 2019 10:52:00 -0800
From:   "Paul E. McKenney" <paulmck@...ux.ibm.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     linux-kernel@...r.kernel.org, mingo@...nel.org,
        jiangshanlai@...il.com, dipankar@...ibm.com,
        akpm@...ux-foundation.org, mathieu.desnoyers@...icios.com,
        josh@...htriplett.org, tglx@...utronix.de, peterz@...radead.org,
        rostedt@...dmis.org, dhowells@...hat.com, edumazet@...gle.com,
        fweisbec@...il.com, oleg@...hat.com, joel@...lfernandes.org,
        Radim Krčmář <rkrcmar@...hat.com>,
        kvm@...r.kernel.org
Subject: Re: [PATCH tip/core/rcu 2/2] virt/kvm: Replace spin_is_locked() with
 lockdep

On Wed, Jan 09, 2019 at 11:36:23PM +0100, Paolo Bonzini wrote:
> On 09/01/19 23:21, Paul E. McKenney wrote:
> > lockdep_assert_held() is better suited to checking locking requirements,
> > since it only checks if the current thread holds the lock regardless of
> > whether someone else does. This is also a step towards possibly removing
> > spin_is_locked().
> > 
> > Signed-off-by: Paul E. McKenney <paulmck@...ux.ibm.com>
> > Cc: Paolo Bonzini <pbonzini@...hat.com>
> > Cc: "Radim Krčmář" <rkrcmar@...hat.com>
> > Cc: <kvm@...r.kernel.org>
> > ---
> >  virt/kvm/kvm_main.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> > index 1f888a103f78..ec758bb7eeba 100644
> > --- a/virt/kvm/kvm_main.c
> > +++ b/virt/kvm/kvm_main.c
> > @@ -4078,7 +4078,7 @@ static int kvm_suspend(void)
> >  static void kvm_resume(void)
> >  {
> >  	if (kvm_usage_count) {
> > -		WARN_ON(raw_spin_is_locked(&kvm_count_lock));
> > +		lockdep_assert_held(&kvm_count_lock);
> >  		hardware_enable_nolock(NULL);
> >  	}
> >  }
> 
> Acked-by: Paolo Bonzini <pbonzini@...hat.com>

Applied, thank you!

							Thanx, Paul