linux-kernel - Re: [PATCH 38/41] scsi: sym53c8xx_2: sym_hipd: mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 10 Jan 2019 13:55:31 -0600
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 38/41] scsi: sym53c8xx_2: sym_hipd: mark expected switch
 fall-throughs

Hi,

Friendly ping (second one):

Who can ack/review/take this patch, please?

Thanks
--
Gustavo

On 12/19/18 6:08 PM, Gustavo A. R. Silva wrote:
> Hi,
> 
> Friendly ping:
> 
> Who can ack or review this patch, please?
> 
> Thanks
> -- 
> Gustavo
> 
> On 11/27/18 10:34 PM, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>>
>> Addresses-Coverity-ID: 114996 ("Missing break in switch")
>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
>> ---
>>   drivers/scsi/sym53c8xx_2/sym_hipd.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/scsi/sym53c8xx_2/sym_hipd.c b/drivers/scsi/sym53c8xx_2/sym_hipd.c
>> index 0a2a54517b15..054fb0599263 100644
>> --- a/drivers/scsi/sym53c8xx_2/sym_hipd.c
>> +++ b/drivers/scsi/sym53c8xx_2/sym_hipd.c
>> @@ -3072,6 +3072,7 @@ static void sym_sir_bad_scsi_status(struct sym_hcb *np, int num, struct sym_ccb
>>               sym_print_addr(cp->cmd, "%s\n",
>>                       s_status == S_BUSY ? "BUSY" : "QUEUE FULL\n");
>>           }
>> +        /* fall through */
>>       default:    /* S_INT, S_INT_COND_MET, S_CONFLICT */
>>           sym_complete_error (np, cp);
>>           break;
>> @@ -4632,6 +4633,7 @@ static void sym_int_sir(struct sym_hcb *np)
>>        *  Negotiation failed.
>>        *  Target does not want answer message.
>>        */
>> +    /* fall through */
>>       case SIR_NEGO_PROTO:
>>           sym_nego_default(np, tp, cp);
>>           goto out;
>>