linux-kernel - Re: [PATCH v15 00/11] livepatch: Atomic replace feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190111174442.6jtvrr7qov3lruxi@treble>
Date:   Fri, 11 Jan 2019 11:44:42 -0600
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Petr Mladek <pmladek@...e.com>
Cc:     Jiri Kosina <jikos@...nel.org>, Miroslav Benes <mbenes@...e.cz>,
        Jason Baron <jbaron@...mai.com>,
        Joe Lawrence <joe.lawrence@...hat.com>,
        Evgenii Shatokhin <eshatokhin@...tuozzo.com>,
        live-patching@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v15 00/11] livepatch: Atomic replace feature

On Wed, Jan 09, 2019 at 01:43:18PM +0100, Petr Mladek wrote:
> Changes against v14:
> 
>   + Rename klp_active -> klp_added [Josh]
> 
>   + Do not clear klp_added variable in klp_free*() [Josh]
> 
>   + Rename klp_init_patch_before_free() ->  klp_init_patch_early()
>     [Josh]
> 
>   + Do not call klp_free_patch() when
>     kobject_init_and_add(&patch->kobj) fails in 3rd patch.
>     The final code stays the same after the refactoring
>     in 5th patch. [Josh]
> 
>   + Better 4th patch subject [Josh]
> 
>   + Use safe iterators in klp_free() functions already in 7th
>     patch instead of in 8th [Josh]
> 
>   + Rename free_all -> nops_only and revert the logic in
>     klp_free*() and klp_unpatch_object*() functions [Josh]
> 
>   + Do not refuse loading conflicting patches. Just remove
>     the ordering (stacking) [Josh]
> 
>   + fixed typos, improved wording [all]

Petr,

This looks great to me.  Thanks for all your patience and hard work!

Acked-by: Josh Poimboeuf <jpoimboe@...hat.com>

-- 
Josh