linux-kernel - Re: [PATCH 2/3] fs: inode_set_flags() replace opencoded set_mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5c9bf6bd-e29b-c985-b686-35f6dc272152@oracle.com>
Date:   Thu, 10 Jan 2019 20:24:43 -0800
From:   Anthony Yznaga <anthony.yznaga@...cle.com>
To:     Vineet Gupta <vineet.gupta1@...opsys.com>,
        linux-kernel@...r.kernel.org
Cc:     linux-snps-arc@...ts.infradead.org, linux-mm@...ck.org,
        peterz@...radead.org, Alexander Viro <viro@...iv.linux.org.uk>,
        "Theodore Ts'o" <tytso@....edu>, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 2/3] fs: inode_set_flags() replace opencoded
 set_mask_bits()



On 1/10/19 4:26 PM, Vineet Gupta wrote:
> It seems that 5f16f3225b0624 and 00a1a053ebe5, both with same commitlog
> ("ext4: atomically set inode->i_flags in ext4_set_inode_flags()")
> introduced the set_mask_bits API, but somehow missed not using it in
> ext4 in the end
>
> Also, set_mask_bits is used in fs quite a bit and we can possibly come up
> with a generic llsc based implementation (w/o the cmpxchg loop)
>
> Cc: Alexander Viro <viro@...iv.linux.org.uk>
> Cc: Theodore Ts'o <tytso@....edu>
> Cc: Peter Zijlstra (Intel) <peterz@...radead.org>
> Cc: linux-fsdevel@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Vineet Gupta <vgupta@...opsys.com>
>

Reviewed-by: Anthony Yznaga <anthony.yznaga@...cle.com>