linux-kernel - Re: [PATCH] printk: Add caller information to printk() output.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7h4lafng3f.fsf@baylibre.com>
Date:   Fri, 11 Jan 2019 11:34:28 -0800
From:   Kevin Hilman <khilman@...libre.com>
To:     Dmitry Vyukov <dvyukov@...gle.com>,
        Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
Cc:     Petr Mladek <pmladek@...e.com>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        syzkaller <syzkaller@...glegroups.com>,
        Fengguang Wu <fengguang.wu@...el.com>
Subject: Re: [PATCH] printk: Add caller information to printk() output.

Dmitry Vyukov <dvyukov@...gle.com> writes:

> On Wed, Jan 2, 2019 at 5:09 PM Dmitry Vyukov <dvyukov@...gle.com> wrote:
>>
>> On Tue, Dec 18, 2018 at 9:58 AM Sergey Senozhatsky
>> <sergey.senozhatsky.work@...il.com> wrote:
>> >
>> > On (12/18/18 09:39), Petr Mladek wrote:
>> > >
>> > > Sergey, are you okay with this squashed patch, please?
>> > >
>> >
>> > Yeah. There are several minor nitpicks, but here is my
>> > Acked-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
>> >
>> >
>> > One final question - can syzbot folks confirm that the patch
>> > helps? Just curious.
>>
>> This slip through the cracks. Tetsuo pinged me and I am testing now.
>> Need to create a set of tests and update parsing code to handle this.
>
> I've pushed support for CONFIG_PRINTK_CALLER to syzkaller/syzbot:
> https://github.com/google/syzkaller/commit/7da2392541a49c3f17b2e7d24e04b84d72b965fb
> Let's see what happens. Limited local testing shows that it's working
> as intended and significatly improves quality of reports and ability
> to make sense out of kernel output.
>
> Tetsuo, thanks for your great persistence with this change!
> Sergey, Petr, thanks for reviews!
>
> +Fengguang, Kevin, maybe you will find this useful for 0-day/kernel-ci.

Yes, will definitely give it a try.  

Kevin