linux-kernel - Re: [PATCH v1 4/6] phy: qcom-qmp: Add QMP V3 USB3 PHY support for msm8998

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190111194513.GA13699@bogus>
Date:   Fri, 11 Jan 2019 13:45:13 -0600
From:   Rob Herring <robh@...nel.org>
To:     Jeffrey Hugo <jhugo@...eaurora.org>
Cc:     kishon@...com, bjorn.andersson@...aro.org, andy.gross@...aro.org,
        david.brown@...aro.org, mturquette@...libre.com, sboyd@...nel.org,
        linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, mark.rutland@....com,
        devicetree@...r.kernel.org, gregkh@...uxfoundation.org,
        balbi@...nel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v1 4/6] phy: qcom-qmp: Add QMP V3 USB3 PHY support for
 msm8998

On Fri, Jan 04, 2019 at 09:50:47AM -0700, Jeffrey Hugo wrote:
> MSM8998 contains a single QMP v3 USB3 phy similar to the existing sdm845
> support, however MSM8998 does not have display port (DP) support.
> 
> Signed-off-by: Jeffrey Hugo <jhugo@...eaurora.org>
> ---
>  .../devicetree/bindings/phy/qcom-qmp-phy.txt       |   5 +
>  drivers/phy/qualcomm/phy-qcom-qmp.c                | 142 +++++++++++++++++++++
>  drivers/phy/qualcomm/phy-qcom-qmp.h                |   4 +
>  3 files changed, 151 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
> index 41a1074..6061b6f 100644
> --- a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
> +++ b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
> @@ -9,6 +9,7 @@ Required properties:
>  	       "qcom,ipq8074-qmp-pcie-phy" for PCIe phy on IPQ8074
>  	       "qcom,msm8996-qmp-pcie-phy" for 14nm PCIe phy on msm8996,
>  	       "qcom,msm8996-qmp-usb3-phy" for 14nm USB3 phy on msm8996,
> +	       "qcom,msm8998-qmp-usb3-phy" for USB3 QMP V3 phy on msm8998,

Please make bindings a separate patch. Combining patch 1 and 2 
binding changes is fine.

Rob