linux-kernel - Re: [PATCH 3/4] crypto: hisilicon: Add HiSilicon ZIP accelerator support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190111060859.k647ltxukywjmi3l@gondor.apana.org.au>
Date:   Fri, 11 Jan 2019 14:08:59 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Zhou Wang <wangzhou1@...ilicon.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        linuxarm@...wei.com, Shiju Jose <shiju.jose@...wei.com>,
        Kenneth Lee <liguozhu@...ilicon.com>,
        Hao Fang <fanghao11@...wei.com>
Subject: Re: [PATCH 3/4] crypto: hisilicon: Add HiSilicon ZIP accelerator
 support

On Sat, Dec 22, 2018 at 03:51:44PM +0800, Zhou Wang wrote:
>
> +static struct crypto_alg hisi_zip_zlib = {
> +	.cra_name		= "zlib-deflate",
> +	.cra_flags		= CRYPTO_ALG_TYPE_COMPRESS,
> +	.cra_ctxsize		= sizeof(struct hisi_zip_ctx),
> +	.cra_priority           = 300,
> +	.cra_module		= THIS_MODULE,
> +	.cra_init		= hisi_zip_alloc_comp_ctx,
> +	.cra_exit		= hisi_zip_free_comp_ctx,
> +	.cra_u			= {
> +		.compress = {
> +			.coa_compress	= hisi_zip_compress,
> +			.coa_decompress	= hisi_zip_decompress
> +		}
> +	}
> +};

Please do not add any new implementations using the compress
interface.  You should either use scomp or acomp depending on
whether your driver is synchronous or async.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt