linux-kernel - Re: [PATCH RESEND] crypto: caam - move shared symbols in a common location

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190111062721.47a52keto3u6jfdi@gondor.apana.org.au>
Date:   Fri, 11 Jan 2019 14:27:21 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Horia Geantă <horia.geanta@....com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        "David S. Miller" <davem@...emloft.net>,
        Aymen Sghaier <aymen.sghaier@....com>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-imx <linux-imx@....com>
Subject: Re: [PATCH RESEND] crypto: caam - move shared symbols in a common
 location

On Thu, Jan 10, 2019 at 03:58:12PM +0200, Horia Geantă wrote:
> There are several issues with symbols shared b/w:
> -caam/jr and caam/qi drivers on one hand
> -caam/qi2 driver on the other hand
> 
> Commit 52813ab24959 ("crypto: caam/qi2 - avoid double export") fixed
> some of them, however compilation still fails for CRYPTO_DEV_FSL_CAAM=m
> and CRYPTO_DEV_FSL_DPAA2_CAAM=y.
> 
> Another issue is related to dependency cycles reported by depmod when
> CRYPTO_DEV_FSL_CAAM=n and CRYPTO_DEV_FSL_DPAA2_CAAM=m, as mentioned in
> 82c7b351be3f ("Revert "arm64: defconfig: Enable FSL_MC_BUS and FSL_MC_DPIO"")
> 
> To fix all these, move the symbols shared by these drivers in a common
> location. The only existing possibility is error.c file (note that naming
> doesn't help and should probably change).
> 
> Fixes: 52813ab24959 ("crypto: caam/qi2 - avoid double export")
> Reported-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Horia Geantă <horia.geanta@....com>
> ---
> 
> Resending to fix patchwork tracking.
> Initial submission done inline here:
> https://patchwork.kernel.org/patch/10739071/
> 
>  drivers/crypto/caam/caamalg_qi2.c | 7 -------
>  drivers/crypto/caam/ctrl.c        | 4 ----
>  drivers/crypto/caam/error.c       | 6 ++++++
>  3 files changed, 6 insertions(+), 11 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt