linux-kernel - RE: [PATCH V7 2/2] mmc: tegra: HW Command Queue Support for Tegra SDMMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN7PR12MB2836750BAFFAEAF8436C7C58C2850@BN7PR12MB2836.namprd12.prod.outlook.com>
Date:   Fri, 11 Jan 2019 00:34:57 +0000
From:   Sowjanya Komatineni <skomatineni@...dia.com>
To:     Adrian Hunter <adrian.hunter@...el.com>,
        "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
        Chunyan Zhang <chunyan.zhang@...soc.com>
CC:     "thierry.reding@...il.com" <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>
Subject: RE: [PATCH V7 2/2] mmc: tegra: HW Command Queue Support for Tegra
 SDMMC

>> +static int sdhci_tegra_add_host(struct sdhci_host *host) {
>> +	struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
>> +	struct sdhci_tegra *tegra_host = sdhci_pltfm_priv(pltfm_host);
>> +	struct cqhci_host *cq_host;
>> +	bool dma64;
>> +	int ret;
>> +
>> +	if (!tegra_host->enable_hwcq)
>> +		return sdhci_add_host(host);
>> +
>> +	host->v4_mode = true;
>
>Can you use sdhci_enable_v4_mode() here?

Hi Adrian,
sdhci_read_caps sets v4 mode thru sdhci_do_enable_v4_mode if v4_mode is true
sdhci_setup_host calls sdhci_read_caps so I was setting v4_mode to true so v4 mode gets enabled during read caps.

Thanks
sowjanya