linux-kernel - RE: [PATCH] x86/fpu/init: Add __setup() functions back to fpu/init.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62C1CF205A679448ACBEE7C5EDA2DE3716365B2A@SHSMSX103.ccr.corp.intel.com>
Date:   Fri, 11 Jan 2019 08:30:13 +0000
From:   "Tang, Haoyu" <haoyu.tang@...el.com>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>
CC:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>,
        "x86@...nel.org" <x86@...nel.org>,
        Andy Lutomirski <luto@...nel.org>,
        Nicolai Stange <nstange@...e.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] x86/fpu/init: Add __setup() functions back to fpu/init.c

It doesn't consistent with document: https://www.kernel.org/doc/html/latest/admin-guide/kernel-parameters.html 
I met an init which didn't accept unknown arguments.

Haoyu

-----Original Message-----
From: Sebastian Andrzej Siewior [mailto:bigeasy@...utronix.de] 
Sent: Friday, January 11, 2019 4:12 PM
To: Tang, Haoyu <haoyu.tang@...el.com>
Cc: Thomas Gleixner <tglx@...utronix.de>; Ingo Molnar <mingo@...hat.com>; Borislav Petkov <bp@...en8.de>; H. Peter Anvin <hpa@...or.com>; x86@...nel.org; Andy Lutomirski <luto@...nel.org>; Nicolai Stange <nstange@...e.de>; linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/fpu/init: Add __setup() functions back to fpu/init.c

On 2019-01-11 10:45:53 [+0800], Haoyu Tang wrote:
> __setup() functions were removed in:
> 
>   commit 4f81cbafcce2 ("x86/fpu: Fix early FPU command-line parsing")
> 
> caused that FPU parameter is passed as an argument to init, the dummy
> __setup() functions can avoid this.

why is that bad?

Sebastian