linux-kernel - Re: [PATCH v5 1/3] staging: greybus: gpio: switch GPIO portions to use GPIOLIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 11 Jan 2019 09:36:38 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Nishad Kamdar <nishadkamdar@...il.com>
Cc:     Johan Hovold <johan@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Alex Elder <elder@...nel.org>,
        Rui Miguel Silva <rmfrfs@...il.com>,
        greybus-dev@...ts.linaro.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/3] staging: greybus: gpio: switch GPIO portions to
 use GPIOLIB_IRQCHIP

On Thu, Jan 10, 2019 at 11:24:28PM +0530, Nishad Kamdar wrote:
> Convert the GPIO driver to use the GPIO irqchip library
> GPIOLIB_IRQCHIP instead of reimplementing the same.
> 
> Signed-off-by: Nishad Kamdar <nishadkamdar@...il.com>
> ---
> Changes in v5:
>  - Restore "struct irq_chip irqc" in "struct gb_gpio_controller"
>    This is because we cannot use the gpio-chip irqchip, as that
>    will register the irqchip automatically and possibly in an
>    incompatible way.
> Changes in v4:
>  - Remove changes related to conversion to gpiochip_get_data() to
>    include it as a new patch.
>  - Remove the 'struct irq_chip' field from 'struct gb_gpio_controller'
>    as struct gpio_chip will have an irqchip whenever
>    CONFIG_GPIOLIB_IRQCHIP is selected.
>  - Update the TODO file as per the changes.
> Changes in v3:
>  - Combine patches as into a patch series.
> Changes in v2:
>  - Retained irq.h and irqdomain.h headers.
>  - Dropped function gb_gpio_irqchip_add() and
>    called gpiochip_irqchip_add() from probe().
>  - Referred https://lkml.kernel.org/r/1476054589-28422-1-git-send-email-linus.walleij@linaro.org.

Looks good to me now, thanks for sticking with it.

Reviewed-by: Johan Hovold <johan@...nel.org>

Johan