linux-kernel - Re: [PATCH] drivers/usb/storage: Remove duplicate headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190111091049.GC15610@kroah.com>
Date:   Fri, 11 Jan 2019 10:10:49 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Sabyasachi Gupta <sabyasachi.linux@...il.com>
Cc:     stern@...land.harvard.edu, jrdr.linux@...il.com,
        linux-usb@...r.kernel.org, usb-storage@...ts.one-eyed-alien.net,
        linux-kernel@...r.kernel.org, brajeswar.linux@...il.com
Subject: Re: [PATCH] drivers/usb/storage: Remove duplicate headers

On Thu, Jan 10, 2019 at 12:40:07PM +0530, Sabyasachi Gupta wrote:
> Remove duplicate headers which are included more than once.
> 
> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@...il.com>
> ---
>  drivers/usb/storage/datafab.c    | 1 -
>  drivers/usb/storage/ene_ub6250.c | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/usb/storage/datafab.c b/drivers/usb/storage/datafab.c
> index 09353be..4b1bd56 100644
> --- a/drivers/usb/storage/datafab.c
> +++ b/drivers/usb/storage/datafab.c
> @@ -102,7 +102,6 @@ MODULE_DEVICE_TABLE(usb, datafab_usb_ids);
>  }
>  
>  static struct us_unusual_dev datafab_unusual_dev_list[] = {
> -#	include "unusual_datafab.h"
>  	{ }		/* Terminating entry */
>  };

Nope, this breaks things :(