linux-kernel - Re: [PATCH v2] PM/runtime: Fix autosuspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6922521.G0BVNVQKqm@aspire.rjw.lan>
Date:   Fri, 11 Jan 2019 11:39:34 +0100
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Tony Lindgren <tony@...mide.com>,
        Vincent Guittot <vincent.guittot@...aro.org>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-omap@...r.kernel.org,
        ulf.hansson@...aro.org, ladis@...ux-mips.org
Subject: Re: [PATCH v2] PM/runtime: Fix autosuspend_delay on 32bits arch

On Thursday, January 10, 2019 5:44:31 PM CET Tony Lindgren wrote:
> * Vincent Guittot <vincent.guittot@...aro.org> [190110 09:00]:
> > Cast autosuspend_delay in u64 to make sure that the full computation of
> > expires or slack will be done in u64, even on 32bits arch.
> > Otherwise, any delay greater than 2^31 nsec can overflow if signed 32bits
> > is used when moving delay from msec to nsec
> > 
> > Fixes: 8234f6734c5d ("PM-runtime: Switch autosuspend over to using hrtimers")
> > Reported-by: Tony Lindgren <tony@...mide.com>
> > Tested-by: Tony Lindgren <tony@...mide.com>
> > Signed-off-by: Vincent Guittot <vincent.guittot@...aro.org>
> > ---
> > 
> > Change since v1:
> > - add u64 cast for slack computation
> 
> Still works for me.

Applied, thanks!