linux-kernel - Re: [PATCH v4 08/16] drm/bochs: atomic: use suspend/resume helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <71b9afc8-c984-a837-c12d-a55c5468575f@gmail.com>
Date:   Fri, 11 Jan 2019 13:08:01 +0200
From:   Oleksandr Andrushchenko <andr2000@...il.com>
To:     Gerd Hoffmann <kraxel@...hat.com>, dri-devel@...ts.freedesktop.org,
        David Airlie <airlied@...hat.com>
Cc:     noralf@...nnes.org, David Airlie <airlied@...ux.ie>,
        "open list:DRM DRIVER FOR BOCHS VIRTUAL GPU" 
        <virtualization@...ts.linux-foundation.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 08/16] drm/bochs: atomic: use suspend/resume helpers

On 1/11/19 7:37 AM, Gerd Hoffmann wrote:
> Switch to atomic helpers: drm_mode_config_helper_suspend/resume().
>
> Signed-off-by: Gerd Hoffmann <kraxel@...hat.com>
Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@...m.com>
> ---
>   drivers/gpu/drm/bochs/bochs_drv.c | 11 ++---------
>   1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/bochs/bochs_drv.c b/drivers/gpu/drm/bochs/bochs_drv.c
> index f3dd66ae99..08ba6029d2 100644
> --- a/drivers/gpu/drm/bochs/bochs_drv.c
> +++ b/drivers/gpu/drm/bochs/bochs_drv.c
> @@ -103,11 +103,8 @@ static int bochs_pm_suspend(struct device *dev)
>   	struct drm_device *drm_dev = pci_get_drvdata(pdev);
>   	struct bochs_device *bochs = drm_dev->dev_private;
>   
> -	drm_kms_helper_poll_disable(drm_dev);
> -
>   	drm_fb_helper_set_suspend_unlocked(&bochs->fb.helper, 1);
> -
> -	return 0;
> +	return drm_mode_config_helper_suspend(drm_dev);
>   }
>   
>   static int bochs_pm_resume(struct device *dev)
> @@ -116,12 +113,8 @@ static int bochs_pm_resume(struct device *dev)
>   	struct drm_device *drm_dev = pci_get_drvdata(pdev);
>   	struct bochs_device *bochs = drm_dev->dev_private;
>   
> -	drm_helper_resume_force_mode(drm_dev);
> -
>   	drm_fb_helper_set_suspend_unlocked(&bochs->fb.helper, 0);
> -
> -	drm_kms_helper_poll_enable(drm_dev);
> -	return 0;
> +	return drm_mode_config_helper_resume(drm_dev);
>   }
>   #endif
>