linux-kernel - Re: [PATCH] vfio_pci: set TRACE_INCLUDE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 11 Jan 2019 12:13:35 +1100
From:   Alexey Kardashevskiy <aik@...abs.ru>
To:     Steven Rostedt <rostedt@...dmis.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Alex Williamson <alex.williamson@...hat.com>, kvm@...r.kernel.org,
        Laura Abbott <labbott@...hat.com>,
        Michael Ellerman <mpe@...erman.id.au>,
        Cornelia Huck <cohuck@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vfio_pci: set TRACE_INCLUDE_PATH to fix the build error



On 11/01/2019 01:47, Steven Rostedt wrote:
> On Tue, Jan 08, 2019 at 12:08:03PM +0900, Masahiro Yamada wrote:
>> ---
>>
>>  drivers/vfio/pci/trace.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/vfio/pci/trace.h b/drivers/vfio/pci/trace.h
>> index 228ccdb..4d13e51 100644
>> --- a/drivers/vfio/pci/trace.h
>> +++ b/drivers/vfio/pci/trace.h
>> @@ -94,7 +94,7 @@ TRACE_EVENT(vfio_pci_npu2_mmap,
>>  #endif /* _TRACE_VFIO_PCI_H */
>>  
>>  #undef TRACE_INCLUDE_PATH
>> -#define TRACE_INCLUDE_PATH .
>> +#define TRACE_INCLUDE_PATH ../../drivers/vfio/pci
> 
> Note, the reason why I did not show this method in the samples/trace_events/
> is that there's one "gotcha" that you need to be careful about. It may not be
> an issue here, but please be aware of it.
> 
> The words in TRACE_INCLUDE_PATH can be updated by C preprocessor defines. For
> example, if for some reason you had:
> 
> #define pci special_pci
> 
> The above would turn into:
> 
>  ../../drivers/vfio/special_pci
> 
> and it wont build, and you will be left scratching your head wondering why.

Lovely :) imho it is +1 for
CFLAGS_vfio_pci_nvlink2.o += -I$(src)
and a comment.


-- 
Alexey