linux-kernel - Re: [PATCH v6 00/16] locking/lockdep: Add support for dynamic keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190111124835.GP1900@hirez.programming.kicks-ass.net>
Date:   Fri, 11 Jan 2019 13:48:35 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Bart Van Assche <bvanassche@....org>
Cc:     mingo@...hat.com, tj@...nel.org, longman@...hat.com,
        johannes.berg@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 00/16] locking/lockdep: Add support for dynamic keys


Hi Bart,

I spotted this new v6 in my inbox and have rebased to it.

On Wed, Jan 09, 2019 at 01:01:48PM -0800, Bart Van Assche wrote:

> The changes compared to v5 are:
> - Modified zap_class() such that it doesn't try to free a list entry that
>   is already being freed.

I however have a question on this; this seems wrong. Once a list entry
is enqueued it should not be reachable anymore. If we can reach an entry
after call_rcu() happened, we've got a problem.

> - Added a patch that fixes an existing bug in add_chain_cache().
> - Improved the code that reports the size needed for lockdep data structures
>   further.
> - Rebased and retested this patch series on top of kernel v5.0-rc1.