lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 11 Jan 2019 15:08:16 +0100 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: linux-kernel@...r.kernel.org Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, stable@...r.kernel.org, Lukas Wunner <lukas@...ner.de>, Mathias Duckeck <m.duckeck@...bus.de>, Frank Pavlic <f.pavlic@...bus.de>, Martin Sperl <kernel@...tin.sperl.org>, Noralf Trønnes <noralf@...nnes.org>, Mark Brown <broonie@...nel.org> Subject: [PATCH 4.4 47/88] spi: bcm2835: Fix book-keeping of DMA termination 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Lukas Wunner <lukas@...ner.de> commit dbc944115eed48af110646992893dc43321368d8 upstream. If submission of a DMA TX transfer succeeds but submission of the corresponding RX transfer does not, the BCM2835 SPI driver terminates the TX transfer but neglects to reset the dma_pending flag to false. Thus, if the next transfer uses interrupt mode (because it is shorter than BCM2835_SPI_DMA_MIN_LENGTH) and runs into a timeout, dmaengine_terminate_all() will be called both for TX (once more) and for RX (which was never started in the first place). Fix it. Signed-off-by: Lukas Wunner <lukas@...ner.de> Fixes: 3ecd37edaa2a ("spi: bcm2835: enable dma modes for transfers meeting certain conditions") Cc: stable@...r.kernel.org # v4.2+ Cc: Mathias Duckeck <m.duckeck@...bus.de> Cc: Frank Pavlic <f.pavlic@...bus.de> Cc: Martin Sperl <kernel@...tin.sperl.org> Cc: Noralf Trønnes <noralf@...nnes.org> Signed-off-by: Mark Brown <broonie@...nel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org> --- drivers/spi/spi-bcm2835.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/spi/spi-bcm2835.c +++ b/drivers/spi/spi-bcm2835.c @@ -341,6 +341,7 @@ static int bcm2835_spi_transfer_one_dma( if (ret) { /* need to reset on errors */ dmaengine_terminate_all(master->dma_tx); + bs->dma_pending = false; bcm2835_spi_reset_hw(master); return ret; }
Powered by blists - more mailing lists