linux-kernel - Re: [PATCH] mm: Introduce GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 12 Jan 2019 08:50:42 -0800
From:   Shakeel Butt <shakeelb@...gle.com>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     Christophe Leroy <christophe.leroy@....fr>,
        Anshuman Khandual <anshuman.khandual@....com>,
        mark.rutland@....com, Michal Hocko <mhocko@...e.com>,
        linux-sh@...r.kernel.org, peterz@...radead.org,
        catalin.marinas@....com, Dave Hansen <dave.hansen@...ux.intel.com>,
        will.deacon@....com, LKML <linux-kernel@...r.kernel.org>,
        Linux MM <linux-mm@...ck.org>, kvmarm@...ts.cs.columbia.edu,
        linux@...linux.org.uk, Ingo Molnar <mingo@...hat.com>,
        Vlastimil Babka <vbabka@...e.cz>,
        David Rientjes <rientjes@...gle.com>, marc.zyngier@....com,
        Mike Rapoport <rppt@...ux.vnet.ibm.com>,
        "Kirill A. Shutemov" <kirill@...temov.name>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-arm-kernel@...ts.infradead.org, ard.biesheuvel@...aro.org,
        robin.murphy@....com, steve.capper@....com,
        christoffer.dall@....com, james.morse@....com,
        aneesh.kumar@...ux.ibm.com,
        Andrew Morton <akpm@...ux-foundation.org>,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] mm: Introduce GFP_PGTABLE

On Sat, Jan 12, 2019 at 7:50 AM Matthew Wilcox <willy@...radead.org> wrote:
>
> On Sat, Jan 12, 2019 at 02:49:29PM +0100, Christophe Leroy wrote:
> > As far as I can see,
> >
> > #define GFP_KERNEL_ACCOUNT (GFP_KERNEL | __GFP_ACCOUNT)
> >
> > So what's the difference between:
> >
> > (GFP_KERNEL_ACCOUNT | __GFP_ZERO) & ~__GFP_ACCOUNT
> >
> > and
> >
> > (GFP_KERNEL | __GFP_ZERO) & ~__GFP_ACCOUNT
>
> Nothing.  But there's a huge difference in the other parts of that same
> file where GFP_ACCOUNT is _not_ used.
>
> I think this unification is too small to bother with.  Something I've
> had on my todo list for some time and have not done anything about
> is to actually unify all of the architecture pte/pmd/... allocations.
> There are tricks some architectures use that others would benefit from.

Can you explain a bit more on this? If this is too low priority on
your todo list then maybe me or someone else can pick that up.

Shakeel