linux-kernel - RE: [PATCH v2] soc: imx: Break dependency on SOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM0PR04MB4211C5626B91ACC4F5F2431B80860@AM0PR04MB4211.eurprd04.prod.outlook.com>
Date:   Sat, 12 Jan 2019 03:14:14 +0000
From:   Aisheng Dong <aisheng.dong@....com>
To:     Shawn Guo <shawnguo@...nel.org>, Abel Vesa <abel.vesa@....com>
CC:     Sascha Hauer <kernel@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        dl-linux-imx <linux-imx@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] soc: imx: Break dependency on SOC_IMX8MQ for GPCv2

> From: Shawn Guo [mailto:shawnguo@...nel.org]
> Sent: Saturday, January 12, 2019 11:09 AM
> On Sun, Dec 23, 2018 at 01:20:34PM +0000, Abel Vesa wrote:
> > Since this is going to be used on more SoCs than just i.MX8MQ, make
> > the dependency here more generic.
> >
> > Signed-off-by: Abel Vesa <abel.vesa@....com>
> > Reviewed-by: Dong Aisheng <aisheng.dong@....com>
> > ---
> > Changes since v1:
> >  * removed the SOC_IMX7D since it's included by ARCH_MXC
> 
> This should really be mentioned in the commit log.
> 

Yes, you're right. We should put it in commit log.

Abel,
Would you resend with this updated?

Regards
Dong Aisheng

> Shawn
> 
> >    as suggested by Dong Aisheng.
> >
> >  drivers/soc/imx/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig index
> > 2112d18..d80f899 100644
> > --- a/drivers/soc/imx/Kconfig
> > +++ b/drivers/soc/imx/Kconfig
> > @@ -2,7 +2,7 @@ menu "i.MX SoC drivers"
> >
> >  config IMX_GPCV2_PM_DOMAINS
> >  	bool "i.MX GPCv2 PM domains"
> > -	depends on SOC_IMX7D || SOC_IMX8MQ || (COMPILE_TEST && OF)
> > +	depends on ARCH_MXC || (COMPILE_TEST && OF)
> >  	depends on PM
> >  	select PM_GENERIC_DOMAINS
> >  	default y if SOC_IMX7D
> > --
> > 2.7.4
> >