linux-kernel - Re: [PATCH] platform/x86: intel-hid: Missing power button release on some Dell models

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190113041532.GB1349@wrath>
Date:   Sat, 12 Jan 2019 20:15:32 -0800
From:   Darren Hart <dvhart@...radead.org>
To:     Mario.Limonciello@...l.com
Cc:     jerome.debretagne@...il.com, alex.hung@...onical.com,
        platform-driver-x86@...r.kernel.org, andy@...radead.org,
        rjw@...ysocki.net, cwhuang@...roid-x86.org,
        tristian.celestin@...look.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: intel-hid: Missing power button release on
 some Dell models

On Mon, Jan 07, 2019 at 03:36:48PM +0000, Mario.Limonciello@...l.com wrote:
> 
> 
> > -----Original Message-----
> > From: platform-driver-x86-owner@...r.kernel.org <platform-driver-x86-
> > owner@...r.kernel.org> On Behalf Of Jérôme de Bretagne
> > Sent: Sunday, January 6, 2019 11:57 AM
> > To: Alex Hung
> > Cc: platform-driver-x86@...r.kernel.org; Andy Shevchenko; Darren Hart;
> > Limonciello, Mario; Rafael J. Wysocki; Chih-Wei Huang; Tristian Celestin; linux-
> > kernel@...r.kernel.org
> > Subject: [PATCH] platform/x86: intel-hid: Missing power button release on some
> > Dell models
> > 
> > 
> > [EXTERNAL EMAIL]
> > 
> > Power button suspend for some Dell models was added in:
> > 
> > commit 821b85366284 (intel-hid: Power button suspend on Dell Latitude 7275)

I've addressed this one, but please do run checkpatch and correct reported
errors in the future. It checks commit reference format.

> > 
> > by checking against the power button press notification (0xCE) to report
> > the power button press event. The corresponding power button release
> > notification (0xCF) was caught and ignored to stop it from being reported
> > as an "unknown event" in the logs.
> > 
> > The missing button release event is creating issues on Android-x86, as
> > reported on the project mailing list for a Dell Latitude 5175 model, since
> > the events are expected in down/up pairs.
> > 
> > Report the power button release event to fix this issue.
> > 
> > Link: https://groups.google.com/forum/#!topic/android-x86/aSwZK9Nf9Ro
> > Tested-by: Tristian Celestin <tristian.celestin@...look.com>
> > Tested-by: Jérôme de Bretagne <jerome.debretagne@...il.com>
> > Signed-off-by: Jérôme de Bretagne <jerome.debretagne@...il.com>

Queued for testing, thanks for the patch.

-- 
Darren Hart
VMware Open Source Technology Center