linux-kernel - Re: [PATCH v2] RDMA/cma: Rollback source IP address if failing to acquire device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190114222852.GA22588@ziepe.ca>
Date:   Mon, 14 Jan 2019 15:28:52 -0700
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Myungho Jung <mhjungk@...il.com>
Cc:     Doug Ledford <dledford@...hat.com>,
        Parav Pandit <parav@...lanox.com>, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] RDMA/cma: Rollback source IP address if failing to
 acquire device

On Wed, Jan 09, 2019 at 10:27:31PM -0800, Myungho Jung wrote:
> If cma_acquire_dev_by_src_ip() returns error in addr_handler(), the
> device state changes back to RDMA_CM_ADDR_BOUND but the resolved source
> IP address is still left. After that, if rdma_destroy_id() is called
> after rdma_listen(), the device is freed without removed from
> listen_any_list in cma_cancel_operation(). Revert to the previous IP
> address if acquiring device fails.
> 
> Reported-by: syzbot+f3ce716af730c8f96637@...kaller.appspotmail.com
> Signed-off-by: Myungho Jung <mhjungk@...il.com>
> Reviewed-by: Parav Pandit <parav@...lanox.com>
> ---
>  drivers/infiniband/core/cma.c | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)

Applied to for-next, thanks

Jason