linux-kernel - Re: [PATCH v4] cpufreq: s5pv210: Defer probe if getting regulators fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJKOXPfvR6vATPiWbef_JiSJX78PkJxRXjF2xK7EYr5B3e8HbA@mail.gmail.com>
Date:   Mon, 14 Jan 2019 08:51:59 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Paweł Chmiel <pawel.mikolaj.chmiel@...il.com>
Cc:     kgene@...nel.org, viresh.kumar@...aro.org, rjw@...ysocki.net,
        linux-arm-kernel@...ts.infradead.org,
        "linux-samsung-soc@...r.kernel.org" 
        <linux-samsung-soc@...r.kernel.org>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] cpufreq: s5pv210: Defer probe if getting regulators fail

On Sun, 13 Jan 2019 at 20:58, Paweł Chmiel
<pawel.mikolaj.chmiel@...il.com> wrote:
>
> There is possibility, that when probing driver, regulators are not yet
> initialized. In this case we should return EPROBE_DEFER and wait till
> they're initialized, since they're required currently for cpufreq driver
> to work. Also move regulator initialization code at beginning of probe,
> so we can defer as fast as posibble.
>
> Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@...il.com>
> ---
> Changes from v3:
>   - Zero dmc_base pointers after unmapping them
>   - If getting vddarm regulator fails just return, no need to do goto
>     jump which would do the same
>
> Changes from v2:
>   - Handle all error paths in probe
>
> Changes from v1:
>   - Fix compilation error
>   - Reorganize code so it's smaller

Reviewed-by: Krzysztof Kozlowski <krzk@...nel.org>

Best regards,
Krzysztof