linux-kernel - RE: [PATCH 2/2] arm64: dts: lx2160a: add sata node support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <VI1PR04MB4431BD06BD9651BEEED031E9ED800@VI1PR04MB4431.eurprd04.prod.outlook.com>
Date:   Mon, 14 Jan 2019 09:52:38 +0000
From:   Peng Ma <peng.ma@....com>
To:     Shawn Guo <shawnguo@...nel.org>
CC:     "axboe@...nel.dk" <axboe@...nel.dk>, Leo Li <leoyang.li@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-ide@...r.kernel.org" <linux-ide@...r.kernel.org>
Subject: RE: [PATCH 2/2] arm64: dts: lx2160a: add sata node support



>-----Original Message-----
>From: Shawn Guo <shawnguo@...nel.org>
>Sent: 2019年1月13日 12:06
>To: Peng Ma <peng.ma@....com>
>Cc: axboe@...nel.dk; Leo Li <leoyang.li@....com>; robh+dt@...nel.org;
>mark.rutland@....com; linux-arm-kernel@...ts.infradead.org;
>devicetree@...r.kernel.org; linux-kernel@...r.kernel.org;
>linux-ide@...r.kernel.org
>Subject: Re: [PATCH 2/2] arm64: dts: lx2160a: add sata node support
>
>On Thu, Jan 10, 2019 at 06:05:33PM +0800, Peng Ma wrote:
>> Add sata node support and Enable sata support
>>
>> Signed-off-by: Peng Ma <peng.ma@....com>
>> ---
>>  arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts |   16 +++++++
>>  arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi    |   44
>+++++++++++++++++++++
>>  2 files changed, 60 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
>b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
>> index 6481e5f..aacca27 100644
>> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
>> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts
>> @@ -117,3 +117,19 @@
>>  &usb1 {
>>  	status = "okay";
>>  };
>> +
>> +&sata0 {
>> +	status = "okay";
>> +};
>> +
>> +&sata1 {
>> +	status = "okay";
>> +};
>> +
>> +&sata2 {
>> +	status = "okay";
>> +};
>> +
>> +&sata3 {
>> +	status = "okay";
>> +};
>> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
>b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
>> index a79f5c1..e857a14 100644
>> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
>> @@ -762,5 +762,49 @@
>>  				     <GIC_SPI 209 IRQ_TYPE_LEVEL_HIGH>;
>>  			dma-coherent;
>>  		};
>> +
>> +		sata0: sata@...0000 {
>> +			status = "disabled";
>
>We usually have 'status' at the end of property list.
>
>Shawn
[Peng Ma] 
Ok, got it, thanks yure quick reply.
Regards,
Peng
>
>> +			compatible = "fsl,lx2160a-ahci";
>> +			reg = <0x0 0x3200000 0x0 0x10000>,
>> +			      <0x7 0x100520 0x0 0x4>;
>> +			reg-names = "ahci", "sata-ecc";
>> +			interrupts = <GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH>;
>> +			clocks = <&clockgen 4 3>;
>> +			dma-coherent;
>> +		};
>> +
>> +		sata1: sata@...0000 {
>> +			status = "disabled";
>> +			compatible = "fsl,lx2160a-ahci";
>> +			reg = <0x0 0x3210000 0x0 0x10000>,
>> +			      <0x7 0x100520 0x0 0x4>;
>> +			reg-names = "ahci", "sata-ecc";
>> +			interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
>> +			clocks = <&clockgen 4 3>;
>> +			dma-coherent;
>> +		};
>> +
>> +		sata2: sata@...0000 {
>> +			status = "disabled";
>> +			compatible = "fsl,lx2160a-ahci";
>> +			reg = <0x0 0x3220000 0x0 0x10000>,
>> +			      <0x7 0x100520 0x0 0x4>;
>> +			reg-names = "ahci", "sata-ecc";
>> +			interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
>> +			clocks = <&clockgen 4 3>;
>> +			dma-coherent;
>> +		};
>> +
>> +		sata3: sata@...0000 {
>> +			status = "disabled";
>> +			compatible = "fsl,lx2160a-ahci";
>> +			reg = <0x0 0x3230000 0x0 0x10000>,
>> +			      <0x7 0x100520 0x0 0x4>;
>> +			reg-names = "ahci", "sata-ecc";
>> +			interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
>> +			clocks = <&clockgen 4 3>;
>> +			dma-coherent;
>> +		};
>>  	};
>>  };
>> --
>> 1.7.1
>>