linux-kernel - Re: [PATCH v4 3/8] drm/stm: prepare for drmP.h removal from drm_modeset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 14 Jan 2019 10:59:48 +0100
From:   Benjamin Gaignard <benjamin.gaignard@...aro.org>
To:     Sam Ravnborg <sam@...nborg.org>
Cc:     Alex Deucher <alexander.deucher@....com>,
        Alexey Brodkin <abrodkin@...opsys.com>,
        Andrzej Hajda <a.hajda@...sung.com>,
        Chen Feng <puck.chen@...ilicon.com>,
        Christian Konig <christian.koenig@....com>,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...ux.ie>,
        David Zhou <David1.Zhou@....com>,
        Eric Anholt <eric@...olt.net>,
        Gerd Hoffmann <kraxel@...hat.com>,
        Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <maxime.ripard@...tlin.com>,
        Philippe Cornu <philippe.cornu@...com>,
        Rob Clark <robdclark@...il.com>,
        Rongrong Zou <zourongrong@...il.com>,
        Sean Paul <sean@...rly.run>,
        Tomi Valkeinen <tomi.valkeinen@...com>,
        Vincent Abriou <vincent.abriou@...com>,
        Xinliang Liu <z.liuxinliang@...ilicon.com>,
        Xinwei Kong <kong.kongxinwei@...ilicon.com>,
        Yannick Fertre <yannick.fertre@...com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        ML dri-devel <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH v4 3/8] drm/stm: prepare for drmP.h removal from drm_modeset_helper.h

Le sam. 12 janv. 2019 à 20:33, Sam Ravnborg <sam@...nborg.org> a écrit :
>
> The use of drmP.h is discouraged and removal of it from
> drm_modeset_helper.h caused drm/stm to fail to build.
>
> This patch introduce the necessary fixes to prepare for the
> drmP.h removal from drm_modeset_helper.h.
>
> Build tested on arm and x86 allmodconfig
>
Acked-by: Benjamin Gaignard <benjamin.gaignard@...aro.org>

> Signed-off-by: Sam Ravnborg <sam@...nborg.org>
> Cc: Yannick Fertre <yannick.fertre@...com>
> Cc: Philippe Cornu <philippe.cornu@...com>
> Cc: Benjamin Gaignard <benjamin.gaignard@...aro.org>
> Cc: Vincent Abriou <vincent.abriou@...com>
> Cc: David Airlie <airlied@...ux.ie>
> Cc: Daniel Vetter <daniel@...ll.ch>
> ---
>  drivers/gpu/drm/stm/drv.c  | 4 ++++
>  drivers/gpu/drm/stm/ltdc.c | 7 +++++++
>  2 files changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/stm/drv.c b/drivers/gpu/drm/stm/drv.c
> index 8dec001b9d37..58bf8bae789c 100644
> --- a/drivers/gpu/drm/stm/drv.c
> +++ b/drivers/gpu/drm/stm/drv.c
> @@ -9,15 +9,19 @@
>   */
>
>  #include <linux/component.h>
> +#include <linux/dma-mapping.h>
> +#include <linux/module.h>
>  #include <linux/of_platform.h>
>
>  #include <drm/drm_atomic.h>
>  #include <drm/drm_atomic_helper.h>
>  #include <drm/drm_crtc_helper.h>
> +#include <drm/drm_drv.h>
>  #include <drm/drm_fb_helper.h>
>  #include <drm/drm_fb_cma_helper.h>
>  #include <drm/drm_gem_cma_helper.h>
>  #include <drm/drm_gem_framebuffer_helper.h>
> +#include <drm/drm_vblank.h>
>
>  #include "ltdc.h"
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index 61dd661aa0ac..de29f4713140 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -10,18 +10,25 @@
>
>  #include <linux/clk.h>
>  #include <linux/component.h>
> +#include <linux/interrupt.h>
> +#include <linux/delay.h>
> +#include <linux/module.h>
>  #include <linux/of_address.h>
>  #include <linux/of_graph.h>
> +#include <linux/platform_device.h>
>  #include <linux/reset.h>
>
>  #include <drm/drm_atomic.h>
>  #include <drm/drm_atomic_helper.h>
>  #include <drm/drm_crtc_helper.h>
> +#include <drm/drm_device.h>
>  #include <drm/drm_fb_cma_helper.h>
> +#include <drm/drm_fourcc.h>
>  #include <drm/drm_gem_cma_helper.h>
>  #include <drm/drm_of.h>
>  #include <drm/drm_bridge.h>
>  #include <drm/drm_plane_helper.h>
> +#include <drm/drm_vblank.h>
>
>  #include <video/videomode.h>
>
> --
> 2.12.0
>


-- 
Benjamin Gaignard

Graphic Study Group

Linaro.org │ Open source software for ARM SoCs

Follow Linaro: Facebook | Twitter | Blog