linux-kernel - [RFC PATCH 3/4] watchdog: hpwdt: Add more information into message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 14 Jan 2019 07:36:16 +0500
From:   Ivan Mironov <mironov.ivan@...il.com>
To:     linux-watchdog@...r.kernel.org, mironov.ivan@...il.com
Cc:     linux-kernel@...r.kernel.org,
        Jerry Hoemann <jerry.hoemann@....com>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Guenter Roeck <linux@...ck-us.net>
Subject: [RFC PATCH 3/4] watchdog: hpwdt: Add more information into message

Default NMI handling code prints the same into the kernel log.

Signed-off-by: Ivan Mironov <mironov.ivan@...il.com>
---
 drivers/watchdog/hpwdt.c | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
index e2958df46c69..95d002b5b120 100644
--- a/drivers/watchdog/hpwdt.c
+++ b/drivers/watchdog/hpwdt.c
@@ -155,19 +155,20 @@ static int hpwdt_my_nmi(void)
 static int hpwdt_pretimeout(unsigned int ulReason, struct pt_regs *regs)
 {
 	unsigned int mynmi = hpwdt_my_nmi();
-	static char panic_msg[] =
-		"00: An NMI occurred. Depending on your system the reason "
-		"for the NMI is logged in any one of the following resources:\n"
-		"1. Integrated Management Log (IML)\n"
-		"2. OA Syslog\n"
-		"3. OA Forward Progress Log\n"
-		"4. iLO Event Log";
 
 	if (!mynmi)
 		return NMI_DONE;
 
-	hex_byte_pack(panic_msg, mynmi);
-	nmi_panic(regs, panic_msg);
+	pr_emerg("%02x: An NMI occurred (reason %02x, CPU %d). Depending on "
+		 "your system the reason for the NMI is logged in any one of "
+		 "the following resources:\n"
+		 "1. Integrated Management Log (IML)\n"
+		 "2. OA Syslog\n"
+		 "3. OA Forward Progress Log\n"
+		 "4. iLO Event Log\n",
+		 mynmi, ulReason, smp_processor_id());
+
+	nmi_panic(regs, "hpwdt: NMI: Not continuing");
 
 	return NMI_HANDLED;
 }
-- 
2.20.1