linux-kernel - Re: next/master boot bisection: next-20190114 on sun8i-h2-plus-libretech-all-h3-cc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 14 Jan 2019 19:02:20 +0530
From:   Rohit Kumar <rohitkr@...eaurora.org>
To:     "kernelci.org bot" <bot@...nelci.org>,
        Ajit Pandey <ajitp@...eaurora.org>, tomeu.vizoso@...labora.com,
        guillaume.tucker@...labora.com, Mark Brown <broonie@...nel.org>,
        matthew.hart@...aro.org, khilman@...libre.com,
        enric.balletbo@...labora.com
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        alsa-devel@...a-project.org, Liam Girdwood <lgirdwood@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: next/master boot bisection: next-20190114 on
 sun8i-h2-plus-libretech-all-h3-cc


On 1/14/2019 6:41 PM, kernelci.org bot wrote:
> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
> * This automated bisection report was sent to you on the basis  *
> * that you may be involved with the breaking commit it has      *
> * found.  No manual investigation has been done to verify it,   *
> * and the root cause of the problem may be somewhere else.      *
> * Hope this helps!                                              *
> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
>
> next/master boot bisection: next-20190114 on sun8i-h2-plus-libretech-all-h3-cc
>
> Summary:
>    Start:      8ce4d582f564 Add linux-next specific files for 20190114
>    Details:    https://kernelci.org/boot/id/5c3c411659b51457a76edd34
>    Plain log:  https://storage.kernelci.org//next/master/next-20190114/arm/sunxi_defconfig/lab-baylibre/boot-sun8i-h2-plus-libretech-all-h3-cc.txt
>    HTML log:   https://storage.kernelci.org//next/master/next-20190114/arm/sunxi_defconfig/lab-baylibre/boot-sun8i-h2-plus-libretech-all-h3-cc.html
>    Result:     8780cf1142a5 ASoC: soc-core: defer card probe until all component is added to list
>
> Checks:
>    revert:     PASS
>    verify:     PASS
>
> Parameters:
>    Tree:       next
>    URL:        http://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>    Branch:     master
>    Target:     sun8i-h2-plus-libretech-all-h3-cc
>    CPU arch:   arm
>    Lab:        lab-baylibre
>    Config:     sunxi_defconfig
>    Test suite: boot
>
> Breaking commit found:
>
> -------------------------------------------------------------------------------
> commit 8780cf1142a59568a3aa77959cbd76b2edb6fd81
> Author: Ajit Pandey <ajitp@...eaurora.org>
> Date:   Wed Jan 9 14:17:07 2019 +0530
>
>      ASoC: soc-core: defer card probe until all component is added to list
>      
>      DAI component probe is not called if it is not present
>      in component list during sound card registration.
>      Check if component is available in component list for
>      platform and cpu dai before soundcard registration.
>      
>      Signed-off-by: Ajit Pandey <ajitp@...eaurora.org>
>      Signed-off-by: Rohit kumar <rohitkr@...eaurora.org>
>      Signed-off-by: Mark Brown <broonie@...nel.org>
The fix is already posted via 
https://lore.kernel.org/patchwork/patch/1031226/.

Mark, Can you pick this up. We will still have to consider intel platform

where there is no soc_component associated with platform_name.

Other solution is to revert this patch and use client specific defer 
probe as

done in v1.

https://lore.kernel.org/patchwork/patch/1027560/
https://lore.kernel.org/patchwork/patch/1027561/

> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index 0462b3ec977a..eec92f17dd15 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c
> @@ -1027,7 +1027,6 @@ static int snd_soc_init_platform(struct snd_soc_card *card,
>   				 struct snd_soc_dai_link *dai_link)
>   {
>   	struct snd_soc_dai_link_component *platform = dai_link->platform;
> -
>   	/*
>   	 * FIXME
>   	 *
> @@ -1129,6 +1128,14 @@ static int soc_init_dai_link(struct snd_soc_card *card,
>   			link->name);
>   		return -EINVAL;
>   	}
> +
> +	/*
> +	 * Defer card registartion if platform dai component is not added to
> +	 * component list.
> +	 */
> +	if (!soc_find_component(link->platform->of_node, link->platform->name))
> +		return -EPROBE_DEFER;
> +
>   	/*
>   	 * CPU device may be specified by either name or OF node, but
>   	 * can be left unspecified, and will be matched based on DAI
> @@ -1140,6 +1147,14 @@ static int soc_init_dai_link(struct snd_soc_card *card,
>   			link->name);
>   		return -EINVAL;
>   	}
> +
> +	/*
> +	 * Defer card registartion if cpu dai component is not added to
> +	 * component list.
> +	 */
> +	if (!soc_find_component(link->cpu_of_node, link->cpu_name))
> +		return -EPROBE_DEFER;
> +
>   	/*
>   	 * At least one of CPU DAI name or CPU device name/node must be
>   	 * specified
> -------------------------------------------------------------------------------
>
>
> Git bisection log:
>
> -------------------------------------------------------------------------------
> git bisect start
> # good: [6b529fb0a3eabf9c4cc3e94c11477250379ce6d8] Merge tag 'for-5.0-rc1-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux
> git bisect good 6b529fb0a3eabf9c4cc3e94c11477250379ce6d8
> # bad: [8ce4d582f5647052b86f364a070aa26268810d7e] Add linux-next specific files for 20190114
> git bisect bad 8ce4d582f5647052b86f364a070aa26268810d7e
> # bad: [bb937d2e6697b49f6e3fa55ec09951ebbc8717ac] Merge remote-tracking branch 'crypto/master'
> git bisect bad bb937d2e6697b49f6e3fa55ec09951ebbc8717ac
> # bad: [04bab95e799a00ffe1b2980e1c786ac9a94f8026] Merge remote-tracking branch 'renesas/next'
> git bisect bad 04bab95e799a00ffe1b2980e1c786ac9a94f8026
> # bad: [5726796d7b631fe9af2202c1ce66232a79984a19] Merge remote-tracking branch 'devicetree-fixes/dt/linus'
> git bisect bad 5726796d7b631fe9af2202c1ce66232a79984a19
> # good: [34aea5d2c46b2581ddf0b78a6119f85c1b3a8d1d] Merge remote-tracking branch 'net/master'
> git bisect good 34aea5d2c46b2581ddf0b78a6119f85c1b3a8d1d
> # bad: [e1faf5c97ee3194c3f3e0b5dc86b3e1490c323d9] Merge remote-tracking branch 'usb-serial-fixes/usb-linus'
> git bisect bad e1faf5c97ee3194c3f3e0b5dc86b3e1490c323d9
> # good: [49ff71f99a8826eda5cee76b69f15600d1cbf4b2] Merge remote-tracking branch 'rdma-fixes/for-rc'
> git bisect good 49ff71f99a8826eda5cee76b69f15600d1cbf4b2
> # bad: [04eb1efcd614d6f067b76a355b3a3599667959dc] ASoC: soc-core: Hold client_mutex around soc_init_dai_link()
> git bisect bad 04eb1efcd614d6f067b76a355b3a3599667959dc
> # good: [a41d9dbf5dac5b6a1283ee8001f22807d18352ea] ASoC: qdsp6: q6asm-dai: Fix a small memory leak
> git bisect good a41d9dbf5dac5b6a1283ee8001f22807d18352ea
> # good: [6175471755075d256c1c654151fc1cad183c1e33] ASoC: ti: davinci-mcasp: Move context save/restore to runtime_pm callbacks
> git bisect good 6175471755075d256c1c654151fc1cad183c1e33
> # good: [44fabd8cdaaa3acb80ad2bb3b5c61ae2136af661] ASoC: atom: fix a missing check of snd_pcm_lib_malloc_pages
> git bisect good 44fabd8cdaaa3acb80ad2bb3b5c61ae2136af661
> # bad: [239b8b34a856777e562373ae0de605536a7ccade] ASoC: Intel: Boards: move the codec PLL configuration to _init
> git bisect bad 239b8b34a856777e562373ae0de605536a7ccade
> # bad: [8780cf1142a59568a3aa77959cbd76b2edb6fd81] ASoC: soc-core: defer card probe until all component is added to list
> git bisect bad 8780cf1142a59568a3aa77959cbd76b2edb6fd81
> # first bad commit: [8780cf1142a59568a3aa77959cbd76b2edb6fd81] ASoC: soc-core: defer card probe until all component is added to list
> -------------------------------------------------------------------------------

-- 
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
of the Code Aurora Forum, hosted by the Linux Foundation.