[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190114144202.27315-4-benjamin.gaignard@st.com>
Date: Mon, 14 Jan 2019 15:41:58 +0100
From: Benjamin Gaignard <benjamin.gaignard@...com>
To: <broonie@...nel.org>, <robh@...nel.org>, <arnd@...db.de>
CC: <linux-kernel@...r.kernel.org>, <loic.pallardy@...com>,
<benjamin.gaignard@...aro.org>,
Benjamin Gaignard <benjamin.gaignard@...com>
Subject: [RFC 3/7] base: Add calls to domains controller
To avoid modifying all the drivers call domainsctrl_set_default_config
before probe to apply the configuration define in device node (if any).
When unbinding the device try to apply configuration named "unbind".
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@...com>
---
drivers/base/dd.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/base/dd.c b/drivers/base/dd.c
index 8ac10af17c00..2880fe893096 100644
--- a/drivers/base/dd.c
+++ b/drivers/base/dd.c
@@ -20,6 +20,7 @@
#include <linux/device.h>
#include <linux/delay.h>
#include <linux/dma-mapping.h>
+#include <linux/domainsctrl.h>
#include <linux/init.h>
#include <linux/module.h>
#include <linux/kthread.h>
@@ -478,6 +479,10 @@ static int really_probe(struct device *dev, struct device_driver *drv)
re_probe:
dev->driver = drv;
+ ret = domainsctrl_set_default_config(dev);
+ if (ret)
+ goto domainctrl_failed;
+
/* If using pinctrl, bind pins now before probing */
ret = pinctrl_bind_pins(dev);
if (ret)
@@ -548,6 +553,8 @@ static int really_probe(struct device *dev, struct device_driver *drv)
blocking_notifier_call_chain(&dev->bus->p->bus_notifier,
BUS_NOTIFY_DRIVER_NOT_BOUND, dev);
pinctrl_bind_failed:
+ domainsctrl_set_config_by_name(dev, "unbind");
+domainctrl_failed:
device_links_no_driver(dev);
devres_release_all(dev);
driver_sysfs_remove(dev);
@@ -970,6 +977,8 @@ static void __device_release_driver(struct device *dev, struct device *parent)
device_links_driver_cleanup(dev);
arch_teardown_dma_ops(dev);
+ domainsctrl_set_config_by_name(dev, "unbind");
+
devres_release_all(dev);
dev->driver = NULL;
dev_set_drvdata(dev, NULL);
--
2.15.0
Powered by blists - more mailing lists