linux-kernel - Re: [PATCH v3] scsi/ata: Use unsigned int for cmd's type in ioctls in scsi_host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 13 Jan 2019 21:57:54 -0700
From:   Nathan Chancellor <natechancellor@...il.com>
To:     Bart Van Assche <bvanassche@....org>
Cc:     Jens Axboe <axboe@...nel.dk>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Adaptec OEM Raid Solutions <aacraid@...rosemi.com>,
        "Manoj N. Kumar" <manoj@...ux.ibm.com>,
        "Matthew R. Ochs" <mrochs@...ux.ibm.com>,
        Uma Krishnan <ukrishn@...ux.ibm.com>,
        Bradley Grove <linuxdrivers@...otech.com>,
        Don Brace <don.brace@...rosemi.com>,
        Brian King <brking@...ibm.com>, linux-ide@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
        esc.storagedev@...rosemi.com,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Joel Stanley <joel@....id.au>
Subject: Re: [PATCH v3] scsi/ata: Use unsigned int for cmd's type in ioctls
 in scsi_host_template

On Sun, Jan 13, 2019 at 08:54:35PM -0800, Bart Van Assche wrote:
> On 1/13/19 8:42 PM, Nathan Chancellor wrote:
> > @@ -1292,7 +1292,7 @@ int esas2r_ioctl_handler(void *hostdata, int cmd, void __user *arg)
> >   	ioctl = memdup_user(arg, sizeof(struct atto_express_ioctl));
> >   	if (IS_ERR(ioctl)) {
> >   		esas2r_log(ESAS2R_LOG_WARN,
> > -			   "ioctl_handler access_ok failed for cmd %d, "
> > +			   "ioctl_handler access_ok failed for cmd %u, "
> >   			   "address %p", cmd,
> >   			   arg);
> >   		return PTR_ERR(ioctl);
> 
> If you have to repost this patch, please use that opportunity to join the
> above split strings. Additionally, since this patch touches much more SCSI

Sorry, I should have caught that. If I have to post again, I will fix
that.

> code than ATA code I think it should have been sent to Martin instead of to
> Jens. Anyway:
> 

I had Jens, Martin, and James on the 'to' line, with all of the other
maintainers of the individual files on cc. If I should have done it
differently, please let me know.

> Reviewed-by: Bart Van Assche <bvanassche@....org>
> 

Thank you, I will carry this forward if I need to.

Nathan