linux-kernel - Re: [Xen-devel] [PATCH v2 ] always clear the X2APIC_ENABLE bit for PV guest

Open Source and information security mailing list archives

Message-ID: <95b3e181-9226-2ba2-9a92-eb2b5b3ad4e8@oracle.com>
Date:   Mon, 14 Jan 2019 13:09:10 -0500
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Igor Druzhinin <igor.druzhinin@...rix.com>,
        xen-devel@...ts.xen.org, Juergen Gross <jgross@...e.com>
Cc:     Xin Li <talons.lee@...il.com>, Talons Lee <xin.li@...rix.com>,
        Andrew Cooper <andrew.cooper3@...rix.com>,
        Sergey Dyasli <sergey.dyasli@...rix.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [Xen-devel] [PATCH v2 ] always clear the X2APIC_ENABLE bit for PV
 guest

On 1/14/19 7:43 AM, Igor Druzhinin wrote:
> ping?

Applied to for-linus-4.21 (nka 5.0)

(this should have been copied to linux-kernel@...r.kernel.org and to me,
which is partly the reason why it was missed)

-boris


>
> On 10/12/2018 10:03, Xin Li wrote:
>> From: Talons Lee <xin.li@...rix.com>
>>
>> Commit e657fcc clears cpu capability bit instead of using fake cpuid
>> value, the EXTD should always be off for PV guest without depending
>> on cpuid value. So remove the cpuid check in xen_read_msr_safe() to
>> always clear the X2APIC_ENABLE bit.
>>
>> Signed-off-by: Talons Lee <xin.li@...rix.com>
>> Reviewed-by: Juergen Gross <jgross@...e.com>
>>
>> ---
>> CC: Igor Druzhinin <igor.druzhinin@...rix.com>
>> CC: Sergey Dyasli <sergey.dyasli@...rix.com>
>> CC: Andrew Cooper <andrew.cooper3@...rix.com>
>> CC: Juergen Gross <jgross@...e.com>
>>
>> v2:
>> don't use fake cpuid to cheat xen_read_msr_safe(), just always clear
>> the EXTD bit.
>> ---
>>  arch/x86/xen/enlighten_pv.c | 5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c
>> index 4b20082..17cf92b 100644
>> --- a/arch/x86/xen/enlighten_pv.c
>> +++ b/arch/x86/xen/enlighten_pv.c
>> @@ -900,10 +900,7 @@ static u64 xen_read_msr_safe(unsigned int msr, int *err)
>>  	val = native_read_msr_safe(msr, err);
>>  	switch (msr) {
>>  	case MSR_IA32_APICBASE:
>> -#ifdef CONFIG_X86_X2APIC
>> -		if (!(cpuid_ecx(1) & (1 << (X86_FEATURE_X2APIC & 31))))
>> -#endif
>> -			val &= ~X2APIC_ENABLE;
>> +		val &= ~X2APIC_ENABLE;
>>  		break;
>>  	}
>>  	return val;
>>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@...ts.xenproject.org
> https://lists.xenproject.org/mailman/listinfo/xen-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives