linux-kernel - Re: [PATCH] vt: annotate implicit fall throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <287bad0a-ec15-aeac-618a-48673b6bf5f2@embeddedor.com>
Date:   Mon, 14 Jan 2019 14:50:11 -0600
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Mathieu Malaterre <malat@...ian.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Jiri Slaby <jslaby@...e.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vt: annotate implicit fall throughs



On 1/14/19 2:41 PM, Mathieu Malaterre wrote:
> There is a plan to build the kernel with -Wimplicit-fallthrough and
> these places in the code produced warnings (W=1). Fix them up.
> 
> This commit remove the following warning:
> 
>    drivers/tty/vt/vt.c:2112:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    drivers/tty/vt/vt.c:2237:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> 
> Signed-off-by: Mathieu Malaterre <malat@...ian.org>

Acked-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

Thanks, Mathieu.

--
Gustavo

> ---
>   drivers/tty/vt/vt.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
> index 41ec8e5010f3..e4f8caed26af 100644
> --- a/drivers/tty/vt/vt.c
> +++ b/drivers/tty/vt/vt.c
> @@ -2111,6 +2111,7 @@ static void do_con_trol(struct tty_struct *tty, struct vc_data *vc, int c)
>   		lf(vc);
>   		if (!is_kbd(vc, lnm))
>   			return;
> +		/* fall through */
>   	case 13:
>   		cr(vc);
>   		return;
> @@ -2236,6 +2237,7 @@ static void do_con_trol(struct tty_struct *tty, struct vc_data *vc, int c)
>   		vc->vc_ques = (c == '?');
>   		if (vc->vc_ques)
>   			return;
> +		/* fall through */
>   	case ESgetpars:
>   		if (c == ';' && vc->vc_npar < NPAR - 1) {
>   			vc->vc_npar++;
>