linux-kernel - Re: [PATCH] lib/cmdline.c:: annotate implicit fall throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5f05caf6-836e-bc2b-cd2b-009ed1073a5b@embeddedor.com>
Date:   Mon, 14 Jan 2019 15:07:12 -0600
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Mathieu Malaterre <malat@...ian.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lib/cmdline.c:: annotate implicit fall throughs



On 1/14/19 2:21 PM, Mathieu Malaterre wrote:
> There is a plan to build the kernel with -Wimplicit-fallthrough and
> these places in the code produced warnings (W=1). Fix them up.
> 
> This commit remove the following warnings:
> 
>    lib/cmdline.c:137:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    lib/cmdline.c:140:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    lib/cmdline.c:143:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    lib/cmdline.c:146:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    lib/cmdline.c:149:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
> 
> Signed-off-by: Mathieu Malaterre <malat@...ian.org>

Acked-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

> ---
>   lib/cmdline.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/lib/cmdline.c b/lib/cmdline.c
> index 171c19b6888e..dc59d6216318 100644
> --- a/lib/cmdline.c
> +++ b/lib/cmdline.c
> @@ -135,18 +135,23 @@ unsigned long long memparse(const char *ptr, char **retptr)
>   	case 'E':
>   	case 'e':
>   		ret <<= 10;
> +		/* fall through */
>   	case 'P':
>   	case 'p':
>   		ret <<= 10;
> +		/* fall through */
>   	case 'T':
>   	case 't':
>   		ret <<= 10;
> +		/* fall through */
>   	case 'G':
>   	case 'g':
>   		ret <<= 10;
> +		/* fall through */
>   	case 'M':
>   	case 'm':
>   		ret <<= 10;
> +		/* fall through */
>   	case 'K':
>   	case 'k':
>   		ret <<= 10;
>