linux-kernel - Re: [PATCH] lib/assoc_array: annotate implicit fall through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <475381f8-3fdf-5b5e-da34-23d57ae757e7@embeddedor.com>
Date:   Mon, 14 Jan 2019 15:08:46 -0600
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Mathieu Malaterre <malat@...ian.org>,
        David Howells <dhowells@...hat.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lib/assoc_array: annotate implicit fall through



On 1/14/19 2:24 PM, Mathieu Malaterre wrote:
> There is a plan to build the kernel with -Wimplicit-fallthrough and
> this place in the code produced a warning (W=1).
> 
> This commit remove the following warning:
> 
>    lib/assoc_array.c:1110:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> 
> Signed-off-by: Mathieu Malaterre <malat@...ian.org>

Acked-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

> ---
>   lib/assoc_array.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/lib/assoc_array.c b/lib/assoc_array.c
> index c6659cb37033..0b61d3b77e5c 100644
> --- a/lib/assoc_array.c
> +++ b/lib/assoc_array.c
> @@ -1115,6 +1115,7 @@ struct assoc_array_edit *assoc_array_delete(struct assoc_array *array,
>   						index_key))
>   				goto found_leaf;
>   		}
> +		/* fall through */
>   	case assoc_array_walk_tree_empty:
>   	case assoc_array_walk_found_wrong_shortcut:
>   	default:
>