linux-kernel - Re: [PATCH] mmc: core: annotate implicit fall through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aec71dd2-0d4c-30dc-cfc5-3167b54e87d7@embeddedor.com>
Date:   Mon, 14 Jan 2019 15:29:05 -0600
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Mathieu Malaterre <malat@...ian.org>,
        Ulf Hansson <ulf.hansson@...aro.org>
Cc:     linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: core: annotate implicit fall through



On 1/14/19 2:42 PM, Mathieu Malaterre wrote:
> There is a plan to build the kernel with -Wimplicit-fallthrough and
> this place in the code produced a warning (W=1).
> 
> In this particular case rewrote the comment to start with the string "fall
> through", so as to match the regular expression expected by GCC. Truncate
> the comment slightly to fit the max line length of 80 characters.
> 
> This commit remove the following warning:
> 
>    drivers/mmc/core/host.c:196:14: warning: this statement may fall through [-Wimplicit-fallthrough=]
> 
> Signed-off-by: Mathieu Malaterre <malat@...ian.org>

Acked-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

Thanks, Mathieu.

> ---
>   drivers/mmc/core/host.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
> index f57f5de54206..0052d6fed7c8 100644
> --- a/drivers/mmc/core/host.c
> +++ b/drivers/mmc/core/host.c
> @@ -194,7 +194,7 @@ int mmc_of_parse(struct mmc_host *host)
>   	switch (bus_width) {
>   	case 8:
>   		host->caps |= MMC_CAP_8_BIT_DATA;
> -		/* Hosts capable of 8-bit transfers can also do 4 bits */
> +		/* fall through - Hosts capable of 8-bit can also do 4 bits */
>   	case 4:
>   		host->caps |= MMC_CAP_4_BIT_DATA;
>   		break;
>