linux-kernel - Re: [PATCH 0/4] gcov: add Clang support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 14 Jan 2019 14:00:51 -0800
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Tri Vo <trong@...roid.com>
Cc:     oberpar@...ux.ibm.com, Greg Hackmann <ghackmann@...roid.com>,
        LKML <linux-kernel@...r.kernel.org>, kernel-team@...roid.com
Subject: Re: [PATCH 0/4] gcov: add Clang support

On Mon, Jan 14, 2019 at 1:53 PM Tri Vo <trong@...roid.com> wrote:
>
> On Mon, Jan 14, 2019 at 1:33 PM Nick Desaulniers
> <ndesaulniers@...gle.com> wrote:
> >
> > On Mon, Jan 14, 2019 at 1:04 PM Tri Vo <trong@...roid.com> wrote:
> > >
> > > This patch series adds Clang supoprt for gcov.
> > >
> > > Patch 1 refactors existing code in preparation for Clang support. Patches
> > > 2-3 implement necessary LLVM runtime hooks and gcov kernel interfaces.
> > > Patch 4 simplifies config selection.
> > >
> > > Greg Hackmann (2):
> > >   gcov: clang: move common gcc code into gcc_base.c
> > >   gcov: clang support
> > >
> > > Nick Desaulniers (1):
> > >   gcov: clang: link/unlink profiling data set.
> > >
> > > Tri Vo (1):
> > >   gcov: clang: pick GCC vs Clang format depending on compiler
> >
> > Thanks for sending Tri!  Doesn't the output format require llvm-cov, or no?
>
> Yes, .gcda files generated by a Clang-built kernel could only be
> parsed by llvm-cov, but not gcc gcov (at least in my local tests).
>
> llvm-cov documentation also indicates that GCC and LLVM gcov tools are
> not necessarily compatible. "[llvm-cov] is compatible with the gcov
> tool from version 4.2 of GCC and may also be compatible with some
> later versions of gcov."
> https://llvm.org/docs/CommandGuide/llvm-cov.html

Thanks, that's good to know for folks looking to help test.  Note to
reviewers that we're actively using this patch set on arm64 devices.

-- 
Thanks,
~Nick Desaulniers