linux-kernel - Re: [PATCH] fpga: altera_freeze_bridge: remove restriction to socfpga

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANk1AXRtWBWhR3UEihL35pa7YmhPiOTDzHK+nAZe6qmMtQ8_HQ@mail.gmail.com>
Date:   Mon, 14 Jan 2019 16:14:51 -0600
From:   Alan Tull <atull@...nel.org>
To:     Moritz Fischer <moritz.fischer@...us.com>
Cc:     Dinh Nguyen <dinguyen@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-fpga@...r.kernel.org
Subject: Re: [PATCH] fpga: altera_freeze_bridge: remove restriction to socfpga

On Fri, Jan 11, 2019 at 12:42 PM Moritz Fischer
<moritz.fischer@...us.com> wrote:

Hi Moritz,

>
> Hi Alan,
>
> On Thu, Jan 10, 2019 at 3:06 PM Alan Tull <atull@...nel.org> wrote:
> >
> > The Altera Freeze Bridge should not be restricted to ARCH_SOCFPGA
> > since it can be used on other platforms such as Stratix10.
> >
> > Signed-off-by: Alan Tull <atull@...nel.org>
> > ---
> >  drivers/fpga/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> > index 0bb7b5c..0bdbd3d 100644
> > --- a/drivers/fpga/Kconfig
> > +++ b/drivers/fpga/Kconfig
> > @@ -104,7 +104,7 @@ config SOCFPGA_FPGA_BRIDGE
> >
> >  config ALTERA_FREEZE_BRIDGE
> >         tristate "Altera FPGA Freeze Bridge"
> > -       depends on ARCH_SOCFPGA && FPGA_BRIDGE
> > +       depends on FPGA_BRIDGE
>
> Doesn't that need a dependency on HAS_IOMEM at least, then?

Right you are!  Thanks!

Alan

> >         help
> >           Say Y to enable drivers for Altera FPGA Freeze bridges.  A
> >           freeze bridge is a bridge that exists in the FPGA fabric to
> > --
> > 2.7.4
> >
>
> Thanks,
> Moritz