linux-kernel - RE: [PATCH V7 2/2] mmc: tegra: HW Command Queue Support for Tegra SDMMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 15 Jan 2019 03:26:18 +0000
From:   Sowjanya Komatineni <skomatineni@...dia.com>
To:     Chunyan Zhang <zhang.lyra@...il.com>
CC:     Adrian Hunter <adrian.hunter@...el.com>,
        "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
        Chunyan Zhang <chunyan.zhang@...soc.com>,
        "thierry.reding@...il.com" <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>
Subject: RE: [PATCH V7 2/2] mmc: tegra: HW Command Queue Support for Tegra
 SDMMC


>>
>> >> +static int sdhci_tegra_add_host(struct sdhci_host *host) {
>> >> +    struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
>> >> +    struct sdhci_tegra *tegra_host = sdhci_pltfm_priv(pltfm_host);
>> >> +    struct cqhci_host *cq_host;
>> >> +    bool dma64;
>> >> +    int ret;
>> >> +
>> >> +    if (!tegra_host->enable_hwcq)
>> >> +            return sdhci_add_host(host);
>> >> +
>> >> +    host->v4_mode = true;
>> >
>> >Can you use sdhci_enable_v4_mode() here?
>>
>> Hi Adrian,
>> sdhci_read_caps sets v4 mode thru sdhci_do_enable_v4_mode if v4_mode 
>> is true sdhci_setup_host calls sdhci_read_caps so I was setting v4_mode to true so v4 mode gets enabled during read caps.
>>
>
>Hi sowjanya, 
>
>I also would suggest to use sdhci_enable_v4_mode() instead of setting
>host->v4_mode directly.
>Enabling v4_mode in read caps was just because that I was worried about v4 mode would be cleared after reset all on some controllers. If that's not the case for all sd host controllers, I guess it can be removed.
>
>Thanks,
>Chunyan

OK, Will change it and provide updated version. Thanks Andrian and Chunyan.
Sowjanya