[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190115205755.GA4022@bogus>
Date: Tue, 15 Jan 2019 14:57:55 -0600
From: Rob Herring <robh@...nel.org>
To: Viorel Suman <viorel.suman@....com>
Cc: Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>, Timur Tabi <timur@...nel.org>,
Nicolin Chen <nicoleotsuka@...il.com>,
Xiubo Li <Xiubo.Lee@...il.com>,
Fabio Estevam <fabio.estevam@....com>,
"S.j. Wang" <shengjiu.wang@....com>,
Daniel Baluta <daniel.baluta@....com>,
Cosmin Samoila <cosmin.samoila@....com>,
"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
dl-linux-imx <linux-imx@....com>,
Viorel Suman <viorel.suman@...il.com>
Subject: Re: [PATCH v2 4/4] ASoC: add imx-audmix DT binding documentation
On Tue, Jan 08, 2019 at 01:05:51PM +0000, Viorel Suman wrote:
> Add the DT binding documentation for Audio Mixer
> machine driver.
>
> Signed-off-by: Viorel Suman <viorel.suman@....com>
> ---
> .../devicetree/bindings/sound/imx-audmix.txt | 24 ++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/imx-audmix.txt
>
> diff --git a/Documentation/devicetree/bindings/sound/imx-audmix.txt b/Documentation/devicetree/bindings/sound/imx-audmix.txt
> new file mode 100644
> index 0000000..6ac1230
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/imx-audmix.txt
> @@ -0,0 +1,24 @@
> +NXP Audio Mixer (AUDMIX) machine driver.
> +
> +Required properties:
> +===================================
> + - compatible : Compatible list, contains "fsl,imx-audmix"
> +
> + - model : Short audio card description.
> +
> + - dais : Must contain a list of phandles to AUDMIX connected
> + DAIs. The current implementation requires two phandles
> + to SAI interfaces to be provided, the first SAI in the
> + list being used to route the AUDMIX output.
> +
> + - audmix-controller : Must contain the phandle to the AUDMIX device node.
I don't think you need 2 nodes for this as this one is just a virtual
device. Just add the dais property to the audmix node.
Rob
Powered by blists - more mailing lists