linux-kernel - Re: [PATCH] tracing: Replace kzalloc with kcalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <659f9838-9e3f-2ba8-3b02-9f19192bc252@embeddedor.com>
Date:   Tue, 15 Jan 2019 15:16:20 -0600
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tracing: Replace kzalloc with kcalloc



On 1/15/19 3:12 PM, Steven Rostedt wrote:
> On Mon, 14 Jan 2019 22:34:08 -0600
> "Gustavo A. R. Silva" <gustavo@...eddedor.com> wrote:
> 
>> Replace kzalloc() function with its 2-factor argument form, kcalloc().
>>
>> This patch replaces cases of:
>>
>> 	kzalloc(a * b, gfp)
>>
>> with:
>> 	kcalloc(a * b, gfp)
> 
> I think you meant:
> 
> 	kcalloc(a, b, gfp)
> 

Yep. copy/paste error. :/

Thanks
--
Gustavo

> -- Steve
> 
>>
>> This code was detected with the help of Coccinelle.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
>> ---
>>   kernel/trace/trace_probe.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
>> index 9962cb5da8ac..57f0cbaf9c58 100644
>> --- a/kernel/trace/trace_probe.c
>> +++ b/kernel/trace/trace_probe.c
>> @@ -429,7 +429,7 @@ static int traceprobe_parse_probe_arg_body(char *arg, ssize_t *size,
>>   			 parg->count);
>>   	}
>>   
>> -	code = tmp = kzalloc(sizeof(*code) * FETCH_INSN_MAX, GFP_KERNEL);
>> +	code = tmp = kcalloc(FETCH_INSN_MAX, sizeof(*code), GFP_KERNEL);
>>   	if (!code)
>>   		return -ENOMEM;
>>   	code[FETCH_INSN_MAX - 1].op = FETCH_OP_END;
>> @@ -501,7 +501,7 @@ static int traceprobe_parse_probe_arg_body(char *arg, ssize_t *size,
>>   	code->op = FETCH_OP_END;
>>   
>>   	/* Shrink down the code buffer */
>> -	parg->code = kzalloc(sizeof(*code) * (code - tmp + 1), GFP_KERNEL);
>> +	parg->code = kcalloc(code - tmp + 1, sizeof(*code), GFP_KERNEL);
>>   	if (!parg->code)
>>   		ret = -ENOMEM;
>>   	else
>