linux-kernel - Re: linux-next: Fixes tag needs some work in the nfs-anna tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hbm4hfu45.wl-tiwai@suse.de>
Date:   Tue, 15 Jan 2019 23:12:26 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Chuck Lever <chuck.lever@...cle.com>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Anna Schumaker <Anna.Schumaker@...app.com>,
        Trond Myklebust <trondmy@...il.com>,
        Linux NFS Mailing List <linux-nfs@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Paul Gortmaker <paul.gortmaker@...driver.com>
Subject: Re: linux-next: Fixes tag needs some work in the nfs-anna tree

On Tue, 15 Jan 2019 22:41:21 +0100,
Chuck Lever wrote:
> 
> Hi Stephen-
> 
> On Jan 15, 2019, at 4:38 PM, Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> 
> > [I am experimenting with checking the Fixes tags in commits in linux-next.
> > Please let me know if you think I am being too strict.]
> > 
> > Hi all,
> > 
> > Commit
> > 
> >  deaa5c96c2f7 ("SUNRPC: Address Kerberos performance/behavior regression")
> > 
> > has problem with this Fixes tag:
> > 
> >  Fixes: 918f3c1fe83c ("SUNRPC: Improve latency for interactive ... ")
> > 
> > The subject should match the subject of the fixed commit.
> > 
> > -- 
> > Cheers,
> > Stephen Rothwell
> 
> I shortened the commit title so that the Fixes: line is shorter than 68
> characters. I can leave these titles alone if that's preferred.

I've sometimes shorted the subject like the above, too, as I find a
too long text annoying.  Maybe the partial string matching should
suffice, especially when it ends with "..." ?


thanks,

Takashi