lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20190115235152.32499-1-voytikd@gmail.com> Date: Wed, 16 Jan 2019 00:51:52 +0100 From: voytikd@...il.com To: "James E . J . Bottomley" <jejb@...ux.ibm.com> Cc: "Martin K . Petersen" <martin.petersen@...cle.com>, Ketan Mukadam <ketan.mukadam@...adcom.com>, Jitendra Bhivare <jitendra.bhivare@...adcom.com>, linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org, Dmitry Voytik <voytikd@...il.com> Subject: [PATCH] scsi: be2iscsi: fix potential NULL pointer dereference From: Dmitry Voytik <voytikd@...il.com> Fix potential NULL pointer dereference wich might happen in function beiscsi_alloc_mem() if kmalloc_array() for mem_descr->mem_array fails and as a result deref of NULL occurs while passing parameters to dma_free_coherent(). Signed-off-by: Dmitry Voytik <voytikd@...il.com> --- drivers/scsi/be2iscsi/be_main.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c index 74e260027c7d..7867f7d2aca7 100644 --- a/drivers/scsi/be2iscsi/be_main.c +++ b/drivers/scsi/be2iscsi/be_main.c @@ -2527,8 +2527,11 @@ static int beiscsi_alloc_mem(struct beiscsi_hba *phba) mem_descr->size_in_bytes = phba->mem_req[i]; mem_descr->mem_array = kmalloc_array(j, sizeof(*mem_arr), GFP_KERNEL); - if (!mem_descr->mem_array) + if (!mem_descr->mem_array) { + /* mem_array must point to valid memory. */ + mem_descr->mem_array = mem_arr_orig; goto free_mem; + } memcpy(mem_descr->mem_array, mem_arr_orig, sizeof(struct mem_array) * j); -- 2.20.1
Powered by blists - more mailing lists