lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 15 Jan 2019 11:13:26 +0100 (CET)
From:   Thomas Gleixner <>
Subject: Re:[PATCH]  x86/mm/mem_encrypt_identity : fix error useage to

On Mon, 7 Jan 2019, wrote:

> >> Fix error usage to sizeof. It should not use sizeof to pointer.
> >
> >.... because?
> >
> >The commit message needs to explain what the potential issue could be
> >and why it doesn't matter in this case.
> I see the definition of pte_t may be more than sizeof(unsigned long).
> So I think sizeof(pte_t) is safer.

What exactly is the difference between:

	pte_t	*p;




and what is safer about the latter?

Answer: No difference and nothing is safer because it's exactly the same.

In general we use sizeof(*p) simply because when the data type of p changes
you don't have to update the code, it just works and stays correct.



Powered by blists - more mailing lists