linux-kernel - Re: Clang warning in drivers/gpu/drm/i915/i915

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87won65gzr.fsf@intel.com>
Date:   Tue, 15 Jan 2019 12:53:44 +0200
From:   Jani Nikula <jani.nikula@...ux.intel.com>
To:     Nathan Chancellor <natechancellor@...il.com>,
        Manasi Navare <manasi.d.navare@...el.com>,
        Rodrigo Vivi <rodrigo.vivi@...el.com>
Cc:     Lyude Paul <lyude@...hat.com>,
        Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
        intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: Clang warning in drivers/gpu/drm/i915/i915_debugfs.c

On Tue, 08 Jan 2019, Nathan Chancellor <natechancellor@...il.com> wrote:
> Hi all,
>
> Commit e845f099f1c6 ("drm/i915/dsc: Add Per connector debugfs node for
> DSC support/enable") causes a Clang warning:
>
> drivers/gpu/drm/i915/i915_debugfs.c:4961:17: warning: address of array 'intel_dp->dsc_dpcd' will always evaluate to 'true' [-Wpointer-bool-conversion]
>                 if (intel_dp->dsc_dpcd)
>                 ~~  ~~~~~~~~~~^~~~~~~~
> 1 warning generated.
>
> Did you mean to dereference it or should that print statement just
> always show? I normally would send a patch myself but since I'm not
> familiar with this code, I'd rather not shoot in the dark :) especially
> since it's for a trivial logging statement.

Fixed by fed85691b408 ("drm/i915: Fix the static code analysis warning
in debugfs"), thanks for the report & review on that one.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center