linux-kernel - Re: [PATCH v4 0/5] ov7670 fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190115112413.yvwikkeoiynmsuh7@valkosipuli.retiisi.org.uk>
Date:   Tue, 15 Jan 2019 13:24:13 +0200
From:   Sakari Ailus <sakari.ailus@....fi>
To:     Lubomir Rintel <lkundrak@...sk>
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 0/5] ov7670 fixes

On Tue, Jan 15, 2019 at 12:12:56PM +0100, Lubomir Rintel wrote:
> On Tue, 2019-01-15 at 12:40 +0200, Sakari Ailus wrote:
> > On Tue, Jan 15, 2019 at 09:54:43AM +0100, Lubomir Rintel wrote:
> > > Hi,
> > > 
> > > here are the ov7670 patches originally from the "media: make Marvell camera
> > > work on DT-based OLPC XO-1.75" updated to apply cleanly on top of
> > > <git://linuxtv.org/sailus/media_tree.git> master as requested.
> > > 
> > > I've also added "ov7670: Remove useless use of a ret variable" with my Ack
> > > slapped on it.
> > 
> > Hi Lubomir,
> > 
> > It seems the end result compiles but the intermedia patches do not. Could
> > you resend, please? I'll replace the patches in my tree with a new version
> > then...
> 
> Seems like the order got messed up. It should be sufficient to reorder
> the patches like this:
> 
> pick f42ae764598a ov7670: Remove useless use of a ret variable
> pick 5be2efe0e5bb media: ov7670: split register setting from set_fmt() logic
> pick 38eed963866e media: ov7670: split register setting from set_framerate() logic
> pick 97be3c31de46 media: ov7670: hook s_power onto v4l2 core
> pick 56c292d92642 media: ov7670: control clock along with power
> 
> (With "git rebase -i 87680151c22eee5b3bb6361fb8d18d765a9d8aff")

Oh well. Done; let's see if that works better...

-- 
Sakari Ailus