linux-kernel - Re: [PATCH 0/8] nvmem: Various small fixes and improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 15 Jan 2019 12:40:37 +0000
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Alban Bedel <albeu@...e.fr>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/8] nvmem: Various small fixes and improvements

On 06/01/2019 19:28, Alban Bedel wrote:
> Hi,
> 
> this series is mostly small bug fixes, but also add a new API
> to make things simpler in drivers that need to request an optional cell.
> 
> Alban Bedel (8):
>    nvmem: core: Set the provider read-only when no write callback is
>      given
>    nvmem: core: Fix of_nvmem_cell_get() for optional cells
>    nvmem: Add nvmem_cell_get_optional and devm_nvmem_cell_get_optional
>    nvmem: core: Fix cell lookup when no cell is found
>    nvmem: core: Properly handle connection ID in of_nvmem_device_get()
>    nvmem: core: Always reference the device returned by
>      nvmem_device_get()
>    nvmem: core: Fix device reference leak
>    nvmem: core: Avoid useless iterations in nvmem_cell_get_from_lookup()
> 
>   drivers/nvmem/core.c           | 86 +++++++++++++++++++++++++++-------
>   include/linux/nvmem-consumer.h | 16 +++++++
>   2 files changed, 86 insertions(+), 16 deletions(-)
> 

Thanks Alban for the work!
Most of the patches look good to me except nvmem_cell_get_optional()!

Will send out comments on that patch separately!

-srini