linux-kernel - Re: [PATCH] PCI: Fix PCI kconfig menu organization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190115131116.GA28672@lst.de>
Date:   Tue, 15 Jan 2019 14:11:16 +0100
From:   Christoph Hellwig <hch@....de>
To:     Rob Herring <robh@...nel.org>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>, linux-kernel@...r.kernel.org,
        Christoph Hellwig <hch@....de>, linux-pci@...r.kernel.org
Subject: Re: [PATCH] PCI: Fix PCI kconfig menu organization

On Mon, Jan 14, 2019 at 03:35:46PM -0600, Rob Herring wrote:
> After commit eb01d42a7778 ("PCI: consolidate PCI config entry in
> drivers/pci"), all the PCI kconfig options appear below "PCI support"
> rather than within a sub-menu. This is because menuconfig expects all
> kconfig entries to be enclosed in an if/endif section. Add the missing
> if/endif.
> 
> With this, "depends on PCI" is redundant in the sub-menu  entries and
> can be removed.

Thanks, this looks fine to me:

Reviewed-by: Christoph Hellwig <hch@....de>