linux-kernel - Re: [PATCH net] net: phy: phy driver features are mandatory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190115140509.GH19687@lunn.ch>
Date:   Tue, 15 Jan 2019 15:05:09 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Camelia Groza <camelia.groza@....com>
Cc:     f.fainelli@...il.com, hkallweit1@...il.com, davem@...emloft.net,
        oss@...error.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: phy: phy driver features are mandatory

On Tue, Jan 15, 2019 at 02:35:19PM +0200, Camelia Groza wrote:
> Since phy driver features became a link_mode bitmap, phy drivers that
> don't have a list of features configured will cause the kernel to crash
> when probed.
> 
> Prevent the phy driver from registering if the features field is missing.
> 
> Fixes: 719655a14971 ("net: phy: Replace phy driver features u32 with link_mode bitmap")
> Reported-by: Scott Wood <oss@...error.net>
> Signed-off-by: Camelia Groza <camelia.groza@....com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew