linux-kernel - Re: [PATCH v7 1/3] staging: greybus: gpio: switch GPIO portions to use GPIOLIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190115151317.GA17860@kroah.com>
Date:   Tue, 15 Jan 2019 16:13:17 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Nishad Kamdar <nishadkamdar@...il.com>
Cc:     Johan Hovold <johan@...nel.org>, devel@...verdev.osuosl.org,
        Alex Elder <elder@...nel.org>, linux-kernel@...r.kernel.org,
        greybus-dev@...ts.linaro.org
Subject: Re: [PATCH v7 1/3] staging: greybus: gpio: switch GPIO portions to
 use GPIOLIB_IRQCHIP

On Mon, Jan 14, 2019 at 08:26:16PM +0530, Nishad Kamdar wrote:
> Convert the GPIO driver to use the GPIO irqchip library
> GPIOLIB_IRQCHIP instead of reimplementing the same.
> 
> Reviewed-by: Johan Hovold <johan@...nel.org>
> Signed-off-by: Nishad Kamdar <nishadkamdar@...il.com>

Did you test build this patch?

It fails horribly for me:

drivers/staging/greybus/gpio.c: In function ‘gb_gpio_request_handler’:
drivers/staging/greybus/gpio.c:389:34: error: ‘struct gpio_chip’ has no member named ‘irq’
  irq = irq_find_mapping(ggc->chip.irq.domain, event->which);
                                  ^
  CC [M]  drivers/staging/rtl8712/usb_intf.o
drivers/staging/greybus/gpio.c: In function ‘gb_gpio_probe’:
drivers/staging/greybus/gpio.c:577:8: error: implicit declaration of function ‘gpiochip_irqchip_add’; did you mean ‘gpiochip_add’? [-Werror=implicit-function-declaration]
  ret = gpiochip_irqchip_add(gpio, irqc, 0, handle_level_irq,
        ^~~~~~~~~~~~~~~~~~~~
        gpiochip_add


Please be more careful...

greg k-h