linux-kernel - Re: [PATCH 1/2] staging/vboxvideo: Don't set FBINFO_MISC_ALWAYS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190115151549.GP10517@phenom.ffwll.local>
Date:   Tue, 15 Jan 2019 16:15:49 +0100
From:   Daniel Vetter <daniel@...ll.ch>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     DRI Development <dri-devel@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Daniel Vetter <daniel.vetter@...el.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Alexander Kapshuk <alexander.kapshuk@...il.com>
Subject: Re: [PATCH 1/2] staging/vboxvideo: Don't set
 FBINFO_MISC_ALWAYS_SETPAR

On Tue, Jan 15, 2019 at 02:45:53PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 15, 2019 at 01:12:28PM +0100, Daniel Vetter wrote:
> > On Tue, Jan 15, 2019 at 11:38:29AM +0100, Greg Kroah-Hartman wrote:
> > > On Tue, Jan 15, 2019 at 11:27:54AM +0100, Daniel Vetter wrote:
> > > > It's a debug hack flag useful to work around driver bugs. That's not a
> > > > good idea for a new driver. Especially for a new drm driver.
> > > > 
> > > > Aside: the fbdev support should probably be converted over to the new
> > > > generic fbdev support.
> > > > 
> > > > Signed-off-by: Daniel Vetter <daniel.vetter@...el.com>
> > > > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > > > Cc: Hans de Goede <hdegoede@...hat.com>
> > > > Cc: Daniel Vetter <daniel.vetter@...ll.ch>
> > > > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
> > > > Cc: Alexander Kapshuk <alexander.kapshuk@...il.com>
> > > > ---
> > > >  drivers/staging/vboxvideo/vbox_fb.c | 5 -----
> > > >  1 file changed, 5 deletions(-)
> > > > 
> > > 
> > > Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > 
> > Since Hans wants to destage vboxvideo this cycle probably best I merge
> > this through drm-misc? Just to make sure it's not lost.
> 
> Feel free to do so!

Applied, thanks for your review.

I think 2/2 is directly staging material for you (somehow
get_maintainers.pl didn't add you to the cc: list, not sure why ...).
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch