linux-kernel - Re: [PATCH v2] fpga: altera_freeze_bridge: remove restriction to socfpga

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0574de1a-a238-7ad3-1bc2-24d27ff50cba@kernel.org>
Date:   Tue, 15 Jan 2019 11:47:36 -0600
From:   Dinh Nguyen <dinguyen@...nel.org>
To:     Alan Tull <atull@...nel.org>, Moritz Fischer <mdf@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-fpga@...r.kernel.org
Subject: Re: [PATCH v2] fpga: altera_freeze_bridge: remove restriction to
 socfpga

minor nit

On 1/14/19 4:33 PM, Alan Tull wrote:
> The Altera Freeze Bridge should not be restricted to ARCH_SOCFPGA
> since it can be used on other platforms such as Stratix10.
> 
> Signed-off-by: Alan Tull <atull@...nel.org>
> ---
>  drivers/fpga/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> index 0bb7b5c..da5786a 100644
> --- a/drivers/fpga/Kconfig
> +++ b/drivers/fpga/Kconfig
> @@ -104,7 +104,8 @@ config SOCFPGA_FPGA_BRIDGE
>  
>  config ALTERA_FREEZE_BRIDGE
>  	tristate "Altera FPGA Freeze Bridge"
> -	depends on ARCH_SOCFPGA && FPGA_BRIDGE
> +	depends on FPGA_BRIDGE
> +	depends on HAS_IOMEM

can just be:

depends on FPGA_BRIDGE && HAS_IOMEM

Dinh