linux-kernel - Re: [PATCH net] erspan: build the header with the right proto according to erspan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190116.133726.2036063241420588039.davem@davemloft.net>
Date:   Wed, 16 Jan 2019 13:37:26 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     lucien.xin@...il.com
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        u9012063@...il.com
Subject: Re: [PATCH net] erspan: build the header with the right proto
 according to erspan_ver

From: Xin Long <lucien.xin@...il.com>
Date: Mon, 14 Jan 2019 18:10:06 +0800

> As said in draft-foschiano-erspan-03#section4:
> 
>    Different frame variants known as "ERSPAN Types" can be
>    distinguished based on the GRE "Protocol Type" field value: Type I
>    and II's value is 0x88BE while Type III's is 0x22EB [ETYPES].
> 
> So set it properly in erspan_xmit() according to erspan_ver. While at
> it, also remove the unused parameter 'proto' in erspan_fb_xmit().
> 
> Fixes: 94d7d8f29287 ("ip6_gre: add erspan v2 support")
> Reported-by: Jianlin Shi <jishi@...hat.com>
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied and queued up for -stable.